airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] potiuk commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python
Date Thu, 26 Sep 2019 13:53:05 GMT
potiuk commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook
to Google Cloud Python
URL: https://github.com/apache/airflow/pull/6096#discussion_r328620115
 
 

 ##########
 File path: airflow/gcp/operators/pubsub.py
 ##########
 @@ -326,34 +505,68 @@ class PubSubSubscriptionDeleteOperator(BaseOperator):
         For this to work, the service account making the request
         must have domain-wide delegation enabled.
     :type delegate_to: str
+    :param retry: (Optional) A retry object used to retry requests.
+        If None is specified, requests will not be retried.
+    :type retry: google.api_core.retry.Retry
+    :param timeout: (Optional) The amount of time, in seconds, to wait for the request
+        to complete. Note that if retry is specified, the timeout applies to each
+        individual attempt.
+    :type timeout: float
+    :param metadata: (Optional) Additional metadata that is provided to the method.
+    :type metadata: Sequence[Tuple[str, str]]]
+    :param project: (Deprecated) the GCP project ID where the topic will be created
+    :type project: str
     """
-    template_fields = ['project', 'subscription']
+    template_fields = ['project_id', 'subscription']
 
 Review comment:
   Should be OK. Maybe (nice to have) we could add a warning in deprecation message, that
templates won't work ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message