airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] ashb commented on a change in pull request #6175: [AIRFLOW-5545] Fixes recursion in DAG cycle testing
Date Tue, 24 Sep 2019 11:29:03 GMT
ashb commented on a change in pull request #6175: [AIRFLOW-5545] Fixes recursion in DAG cycle
testing
URL: https://github.com/apache/airflow/pull/6175#discussion_r327561642
 
 

 ##########
 File path: tests/models/test_dag.py
 ##########
 @@ -606,6 +606,27 @@ def test_cycle(self):
         with self.assertRaises(AirflowDagCycleException):
             dag.test_cycle()
 
+    def test_long_dag_parsing(self):
+        """
+
+        Ensure DAG Parsing does not break on long DAGs
+        :return:
+        """
+        dag = DAG(
+            'dag',
+            start_date=DEFAULT_DATE,
+            default_args={'owner': 'owner1'})
+
+        # E-> A -> B -> F -> A
+        #       -> C -> F
+        with dag:
+            last = dag
+            for i in range(1,10000):
 
 Review comment:
   ```suggestion
               for i in range(1, 10000):
   ```
   
   To keep pylint happy

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message