airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] ashb commented on a change in pull request #6174: [AIRFLOW-5543] Fix tooltip disappears in tree and graph view
Date Tue, 24 Sep 2019 10:26:16 GMT
ashb commented on a change in pull request #6174: [AIRFLOW-5543] Fix tooltip disappears in
tree and graph view
URL: https://github.com/apache/airflow/pull/6174#discussion_r327536928
 
 

 ##########
 File path: airflow/www/static/js/graph.js
 ##########
 @@ -44,7 +43,10 @@ function update_nodes_states(task_instances) {
         tt += "Duration: " + escapeHtml(convertSecsToHumanReadable(ti.duration)) + "<br>";
         tt += "Started: " + escapeHtml(ti.start_date) + "<br>";
         tt += generateTooltipDateTime(ti.start_date, ti.end_date, dagTZ); // dagTZ has been
defined in dag.html
-        return tt;
+        taskTip.show(tt, this); // taskTip is defined in graph.html
+      })
+      .on('mouseout', function(d,i) {
 
 Review comment:
   Can be simpler: 
   ```suggestion
         .on('mouseout', taskTip.hide))
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message