airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] ashb commented on a change in pull request #6174: [AIRFLOW-5543] Fix tooltip disappears in tree and graph view
Date Tue, 24 Sep 2019 10:26:16 GMT
ashb commented on a change in pull request #6174: [AIRFLOW-5543] Fix tooltip disappears in
tree and graph view
URL: https://github.com/apache/airflow/pull/6174#discussion_r327537996
 
 

 ##########
 File path: airflow/www/templates/airflow/tree.html
 ##########
 @@ -108,6 +109,22 @@
 var diagonal = d3.svg.diagonal()
     .projection(function(d) { return [d.y, d.x]; });
 
+const taskTip = d3.tip()
+  .attr('class', 'tooltip')
+  .style('background', 'black')
+  .style('color', 'white')
+  .style("border", "solid")
+  .style("border-width", "1px")
+  .style("border-radius", "5px")
+  .style("padding", "10px")
+  .direction(function(toolTipHtml) {
 
 Review comment:
   I don't like this - it feels error-prone. Can we instead to `tip.direction(condition ?
'e': 'n')` from inside the on mouseover event handler.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message