airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] ashb commented on a change in pull request #6174: [AIRFLOW-5543] Fix tooltip disappears in tree and graph view
Date Tue, 24 Sep 2019 10:17:32 GMT
ashb commented on a change in pull request #6174: [AIRFLOW-5543] Fix tooltip disappears in
tree and graph view
URL: https://github.com/apache/airflow/pull/6174#discussion_r327534789
 
 

 ##########
 File path: airflow/www/templates/airflow/graph.html
 ##########
 @@ -128,6 +129,17 @@
         'queued': false,
         'no_status': false
     };
+    const taskTip = d3.tip()
+      .attr('class', 'tooltip')
+      .style('background', 'black')
 
 Review comment:
   Rather than defining the stlyes in the JS can we put them in a .css file (as we already
have given this a class)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message