airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] mik-laj commented on a change in pull request #6153: [AIRFLOW-3388] Add support to Array Jobs for AWS Batch Operator
Date Fri, 20 Sep 2019 16:06:54 GMT
mik-laj commented on a change in pull request #6153: [AIRFLOW-3388] Add support to Array Jobs
for AWS Batch Operator
URL: https://github.com/apache/airflow/pull/6153#discussion_r326699348
 
 

 ##########
 File path: airflow/contrib/operators/awsbatch_operator.py
 ##########
 @@ -81,8 +85,8 @@ class AWSBatchOperator(BaseOperator):
     template_fields = ('job_name', 'overrides',)
 
     @apply_defaults
-    def __init__(self, job_name, job_definition, job_queue, overrides, max_retries=4200,
-                 aws_conn_id=None, region_name=None, **kwargs):
+    def __init__(self, job_name, job_definition, job_queue, overrides, array_properties=None,
+                 max_retries=4200, aws_conn_id=None, region_name=None, **kwargs):
 
 Review comment:
   It's backward compatible, because init operator method must use a keyword arguments . It's
a requirements defined by apply_defaults decorator.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message