airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] feluelle commented on a change in pull request #6075: [AIRFLOW-5266] Allow aws_athena_hook to get all query results
Date Fri, 20 Sep 2019 13:13:50 GMT
feluelle commented on a change in pull request #6075: [AIRFLOW-5266] Allow aws_athena_hook
to get all query results
URL: https://github.com/apache/airflow/pull/6075#discussion_r326608845
 
 

 ##########
 File path: airflow/contrib/hooks/aws_athena_hook.py
 ##########
 @@ -157,6 +178,7 @@ def poll_query_status(self, query_execution_id, max_tries=None):
                 break
             if max_tries and try_number >= max_tries:  # Break loop if max_tries reached
                 final_query_state = query_state
+                self.stop_query(query_execution_id)
 
 Review comment:
   You should mention that in the commit :)
   
   It fixes a bug, right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message