airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] mik-laj commented on a change in pull request #5770: [AIRFLOW-5162] GCS Hook Upload Method Improvement
Date Sat, 14 Sep 2019 12:02:12 GMT
mik-laj commented on a change in pull request #5770: [AIRFLOW-5162] GCS Hook Upload Method
Improvement
URL: https://github.com/apache/airflow/pull/5770#discussion_r324422475
 
 

 ##########
 File path: airflow/gcp/hooks/gcs.py
 ##########
 @@ -405,11 +420,9 @@ def create_bucket(self,
         """
         Creates a new bucket. Google Cloud Storage uses a flat namespace, so
         you can't create a bucket with a name that is already in use.
-
         .. seealso::
             For more information, see Bucket Naming Guidelines:
             https://cloud.google.com/storage/docs/bucketnaming.html#requirements
-
 
 Review comment:
   This change prevents the documentation from being built properly. Can you delete it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message