airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] mik-laj commented on a change in pull request #6099: [AIRFLOW-5479] Normalize gcp_conn method in GCP Kubernetes Hook
Date Fri, 13 Sep 2019 21:07:32 GMT
mik-laj commented on a change in pull request #6099: [AIRFLOW-5479] Normalize gcp_conn method
in GCP Kubernetes Hook
URL: https://github.com/apache/airflow/pull/6099#discussion_r324368735
 
 

 ##########
 File path: airflow/gcp/hooks/kubernetes_engine.py
 ##########
 @@ -58,7 +58,7 @@ def __init__(
         self._client = None
         self.location = location
 
-    def get_client(self) -> container_v1.ClusterManagerClient:
 
 Review comment:
   Can you add backward compatibility and deprecation warning?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message