airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] feluelle commented on a change in pull request #5786: [AIRFLOW-5170] [AIRFLOW-5256] Consistent licences for python files and related pylint fixes
Date Thu, 12 Sep 2019 14:39:56 GMT
feluelle commented on a change in pull request #5786:  [AIRFLOW-5170] [AIRFLOW-5256] Consistent
licences for python files and related pylint fixes
URL: https://github.com/apache/airflow/pull/5786#discussion_r323774632
 
 

 ##########
 File path: docs/exts/exampleinclude.py
 ##########
 @@ -149,15 +157,15 @@ def register_source(app, env, modname):
         code, tags = code_tags
 
     if entry is None or entry[0] != code:
-        # print("Registeted", entry)
-
         entry = code, tags, {}, ""
         env._viewcode_modules[modname] = entry  # type: ignore
 
     return True
+# pylint: enable=protected-access
 
 
-def create_node(app, env, relative_path, show_button):
+def create_node(env, relative_path, show_button):
+    """Creates node from module"""
 
 Review comment:
   Same here.
   
   Especially when it is a method where you don't expect a return value. Like `create_node`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message