airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] bharathpalaksha commented on a change in pull request #6034: [AIRFLOW-5343] Remove legacy way of pessimistic disconnect handling
Date Mon, 09 Sep 2019 09:02:43 GMT
bharathpalaksha commented on a change in pull request #6034: [AIRFLOW-5343] Remove legacy way
of pessimistic disconnect handling
URL: https://github.com/apache/airflow/pull/6034#discussion_r322133632
 
 

 ##########
 File path: airflow/config_templates/default_airflow.cfg
 ##########
 @@ -125,11 +125,7 @@ sql_alchemy_pool_recycle = 1800
 # Check connection at the start of each connection pool checkout.
 # Typically, this is a simple statement like “SELECT 1”.
 # More information here: https://docs.sqlalchemy.org/en/13/core/pooling.html#disconnect-handling-pessimistic
-sql_alchemy_pool_pre_ping = False
-
-# How many seconds to retry re-establishing a DB connection after
-# disconnects. Setting this to 0 disables retries.
-sql_alchemy_reconnect_timeout = 300
 
 Review comment:
   pool_pre_ping argument should take care of it and the code for re connect is within sql
alchemy library. We don't have to handle explicitly with new sql alchemy version

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message