airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] milton0825 commented on a change in pull request #6001: [AIRFLOW-XXX] Make Breeze The default integration test environment
Date Thu, 05 Sep 2019 05:11:12 GMT
milton0825 commented on a change in pull request #6001: [AIRFLOW-XXX] Make Breeze The default
integration test environment
URL: https://github.com/apache/airflow/pull/6001#discussion_r321076084
 
 

 ##########
 File path: CONTRIBUTING.md
 ##########
 @@ -695,23 +265,23 @@ pre-commit install --help
 
 ## Docker images for pre-commit hooks
 
-Before running the pre-commit hooks you must first build the docker images locally as described
in
-[Building the images](#building-the-images) chapter.
+Before running the pre-commit hooks you must first build the docker images as described in
+[BREEZE](BREEZE.rst).
 
 Sometimes your image is outdated (when dependencies change) and needs to be rebuilt because
some
-dependencies have been changed. In such case the docker build pre-commit will fail and inform
-you that you should rebuild the image with REBUILD="true" environment variable set.
+dependencies have been changed. In such case the docker build pre-commit will inform
+you that you should rebuild the image.
 
 ## Prerequisites for pre-commit hooks
 
 The pre-commit hooks use several external linters that need to be installed before pre-commit
are run.
-Most of the linters are installed by running `pip install -e .[devel]` in the airflow sources
as they
-are python-only, however there are some that should be installed locally using different
methods.
-In Linux you typically install them with `sudo apt install` on MacOS with `brew install`.
+Each of the checks install its own environmen, so you do not need to install those, but there
are some
 
 Review comment:
   ```suggestion
   Each of the checks install its own environment, so you do not need to install those, but
there are some
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message