airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] kaxil commented on a change in pull request #5987: [AIRFLOW-5388] Add airflow version label to newly created buckets
Date Mon, 02 Sep 2019 18:01:06 GMT
kaxil commented on a change in pull request #5987: [AIRFLOW-5388] Add airflow version label
to newly created buckets
URL: https://github.com/apache/airflow/pull/5987#discussion_r320027971
 
 

 ##########
 File path: airflow/contrib/hooks/gcs_hook.py
 ##########
 @@ -439,6 +440,10 @@ def create_bucket(self,
         self.log.info('Creating Bucket: %s; Location: %s; Storage Class: %s',
                       bucket_name, location, storage_class)
 
+        # Add airflow-version label to the bucket
+        labels = {} or labels
+        labels['airflow-version'] = 'v' + version.replace('.', '-').replace('+', '-')
 
 Review comment:
   hmm... What's your view? 
   
   If others are happy with this, I don't want to veto or stop this change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message