airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] kaxil commented on a change in pull request #5987: [AIRFLOW-5388] Add airflow version label to newly created buckets
Date Mon, 02 Sep 2019 17:49:44 GMT
kaxil commented on a change in pull request #5987: [AIRFLOW-5388] Add airflow version label
to newly created buckets
URL: https://github.com/apache/airflow/pull/5987#discussion_r320026792
 
 

 ##########
 File path: airflow/contrib/hooks/gcs_hook.py
 ##########
 @@ -439,6 +440,10 @@ def create_bucket(self,
         self.log.info('Creating Bucket: %s; Location: %s; Storage Class: %s',
                       bucket_name, location, storage_class)
 
+        # Add airflow-version label to the bucket
+        labels = {} or labels
+        labels['airflow-version'] = 'v' + version.replace('.', '-').replace('+', '-')
 
 Review comment:
   I am against this. I know many companies where they have strict policies on labels.
   
   We currently have this for Dataflow or Dataproc jobs I guess which are temporary jobs but
buckets are long-lived and generally, companies have stricter policies.
   
   If someone wants to add this labels then can add it but we should not add it by default.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message