airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] mik-laj commented on issue #5770: [AIRFLOW-5162] GCS Hook Upload Method Improvement
Date Sun, 01 Sep 2019 02:07:55 GMT
mik-laj commented on issue #5770: [AIRFLOW-5162] GCS Hook Upload Method Improvement
URL: https://github.com/apache/airflow/pull/5770#issuecomment-526879426
 
 
   Unit tests for GCS Hook is available here:
   https://github.com/apache/airflow/blob/master/tests/contrib/hooks/test_gcs_hook.py
   
   When it comes to writing tests for GCP integration, we distinguish two types:
   * Unit tests -  It uses very actively mocking. You should never use authorization data
in these tests. Method calls from the Google library should be mocked.
   * System tests - It uses real DAG examples and uses authorization data. Unfortunately,
they are not yet automatically launched on CI.
   
   Hooks and operators are tested using unit tests, but whole integration is tested using
system tests. I hope you will write unit tests.
   System tests for integration with GCS have not yet been approved, but there is open PR:

   https://github.com/apache/airflow/pull/5951
   My team has been actively working over the past two weeks to increase system test coverage.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message