From commits-return-61940-archive-asf-public=cust-asf.ponee.io@airflow.apache.org Fri Aug 16 14:47:03 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0528E18057A for ; Fri, 16 Aug 2019 16:47:02 +0200 (CEST) Received: (qmail 95382 invoked by uid 500); 16 Aug 2019 14:47:02 -0000 Mailing-List: contact commits-help@airflow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.apache.org Delivered-To: mailing list commits@airflow.apache.org Received: (qmail 95372 invoked by uid 99); 16 Aug 2019 14:47:02 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Aug 2019 14:47:02 +0000 From: GitBox To: commits@airflow.apache.org Subject: [GitHub] [airflow] potiuk commented on a change in pull request #5839: [AIRFLOW-5236] dont reload pip packages for every k8s build Message-ID: <156596682234.3912.5454365133797303484.gitbox@gitbox.apache.org> Date: Fri, 16 Aug 2019 14:47:02 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit potiuk commented on a change in pull request #5839: [AIRFLOW-5236] dont reload pip packages for every k8s build URL: https://github.com/apache/airflow/pull/5839#discussion_r314753060 ########## File path: scripts/ci/kubernetes/docker/build.sh ########## @@ -50,5 +50,10 @@ sudo rm -rf "${AIRFLOW_ROOT}/airflow/www_rbac/node_modules" echo "Copy distro ${AIRFLOW_ROOT}/dist/*.tar.gz ${DIRNAME}/airflow.tar.gz" cp ${AIRFLOW_ROOT}/dist/*.tar.gz "${DIRNAME}/airflow.tar.gz" -cd "${DIRNAME}" && docker build --pull "${DIRNAME}" --tag="${IMAGE}:${TAG}" +pip freeze | grep -v airflow | grep -v postgres > requirements.txt +if [[ "${DO_NOT_PULL}" ]]; then Review comment: Nit: Maybe use AIRFLOW_CONTAINER_SKIP_PULLING_AIRFLOW_IMAGES == "true" ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services