airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (Jira)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-5285) Pre-commit pylint runs over todo files
Date Fri, 23 Aug 2019 20:20:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-5285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914591#comment-16914591
] 

ASF subversion and git services commented on AIRFLOW-5285:
----------------------------------------------------------

Commit d24db825ff5b1a228fddbe09ec1d13d92c94e284 in airflow's branch refs/heads/master from
Jarek Potiuk
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=d24db82 ]

[AIRFLOW-5285] Pylint pre-commit filters out pylint_todo files (#5884)

* [AIRFLOW-5285] Pylint pre-commit filters out pylint_todo files

> Pre-commit pylint runs over todo files
> --------------------------------------
>
>                 Key: AIRFLOW-5285
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5285
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: PR tool
>    Affects Versions: 1.10.5
>            Reporter: Tomasz Urbaszek
>            Priority: Major
>
> Running:
> {code:java}
> pre-commit run --all-files{code}
> runs pylint over files that should be skipped because they are listed in pylint_todo.txt:
> {code:java}
> airflow/utils/operator_helpers.py:1:0: R0401: Cyclic import (airflow.bin.cli -> airflow.jobs
-> airflow.jobs.scheduler_job -> airflow.ti_deps.deps.pool_slots_available_dep ->
airflow.models -> airflow.models.dag) (cyclic-import)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Mime
View raw message