airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-5169) Pass GCP Project ID explicitly to StorageClient in GCSHook
Date Mon, 12 Aug 2019 11:26:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905097#comment-16905097
] 

ASF GitHub Bot commented on AIRFLOW-5169:
-----------------------------------------

kaxil commented on pull request #5783: [AIRFLOW-5169] Pass GCP Project ID explicitly to StorageClient
in GCS…
URL: https://github.com/apache/airflow/pull/5783
 
 
   …Hook
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/)
issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-5169
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   If Project_id is not passed to the StorageClient it tries to infer the Project_ID from
the environment variables or Cloud SDK.
   
   If neither env variables is set nor Cloud SDK is configured it will error with the following
message:
   
   ```
   google.auth.exceptions.DefaultCredentialsError: Could not automatically determine credentials.
Please set GOOGLE_APPLICATION_CREDENTIALS or explicitly create credentials and re-run the
application. For more information, please see https://cloud.google.com/docs/authentication/getting-started
   ```
   
   ### Tests
   
   - [] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   I need some help on adding a test to check that project_id exists when storage client is
created @mik-laj 
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use
it.
     - All the public functions and the classes in the PR contain docstrings that explain
what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md)
so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Pass GCP Project ID explicitly to StorageClient in GCSHook
> ----------------------------------------------------------
>
>                 Key: AIRFLOW-5169
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5169
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: gcp
>    Affects Versions: 1.10.4
>            Reporter: Kaxil Naik
>            Assignee: Kaxil Naik
>            Priority: Major
>
> If Project_id is not passed to the StorageClient it tries to infer the Project_ID from
the environment variables or Cloud SDK.
> If neither env variables is set nor Cloud SDK is configured it will error with the following
message:
> {code}
> google.auth.exceptions.DefaultCredentialsError: Could not automatically determine credentials.
Please set GOOGLE_APPLICATION_CREDENTIALS or explicitly create credentials and re-run the
application. For more information, please see https://cloud.google.com/docs/authentication/getting-started
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Mime
View raw message