airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] mik-laj commented on a change in pull request #5935: [AIRFLOW-5330] Add project_id to Datastore hook and operators
Date Wed, 28 Aug 2019 22:01:44 GMT
mik-laj commented on a change in pull request #5935: [AIRFLOW-5330] Add project_id to Datastore
hook and operators
URL: https://github.com/apache/airflow/pull/5935#discussion_r318811784
 
 

 ##########
 File path: tests/gcp/hooks/datastore.py
 ##########
 @@ -50,12 +52,12 @@ def test_allocate_ids(self, mock_get_conn):
         self.datastore_hook.connection = mock_get_conn.return_value
         partial_keys = []
 
-        keys = self.datastore_hook.allocate_ids(partial_keys)
+        keys = self.datastore_hook.allocate_ids(partial_keys=partial_keys, project_id=GCP_PROJECT_ID)
 
 Review comment:
   I think one is enough for each hook method. But we should check the complete lack - both
in connection and in parameters.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message