airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] nuclearpinguin commented on a change in pull request #5935: [AIRFLOW-5330] Add project_id to Datastore hook and operators
Date Wed, 28 Aug 2019 21:55:49 GMT
nuclearpinguin commented on a change in pull request #5935: [AIRFLOW-5330] Add project_id to
Datastore hook and operators
URL: https://github.com/apache/airflow/pull/5935#discussion_r318809882
 
 

 ##########
 File path: tests/gcp/hooks/datastore.py
 ##########
 @@ -50,12 +52,12 @@ def test_allocate_ids(self, mock_get_conn):
         self.datastore_hook.connection = mock_get_conn.return_value
         partial_keys = []
 
-        keys = self.datastore_hook.allocate_ids(partial_keys)
+        keys = self.datastore_hook.allocate_ids(partial_keys=partial_keys, project_id=GCP_PROJECT_ID)
 
 Review comment:
   Sure, should I duplicate all test or create just one case?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message