airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] ashb commented on a change in pull request #5880: [AIRFLOW-5282] Add default timeout on kubeclient & catch HTTPError
Date Thu, 22 Aug 2019 15:35:02 GMT
ashb commented on a change in pull request #5880: [AIRFLOW-5282] Add default timeout on kubeclient
& catch HTTPError
URL: https://github.com/apache/airflow/pull/5880#discussion_r316746816
 
 

 ##########
 File path: airflow/config_templates/default_airflow.cfg
 ##########
 @@ -776,7 +776,9 @@ tolerations =
 # List of supported params in **kwargs are similar for all core_v1_apis, hence a single config
variable for all apis
 # See:
 #   https://raw.githubusercontent.com/kubernetes-client/python/master/kubernetes/client/apis/core_v1_api.py
-kube_client_request_args =
+# Note that if no _request_timeout is specified, the kubernetes client will wait indefinitely
for kubernetes
+# api responses, which will cause the scheduler to hang. The timeout is specified as [connect
timeout, read timeout]
+kube_client_request_args = {"_request_timeout" : [60,60] }
 
 Review comment:
   ```suggestion
   kube_client_request_args = {{"_request_timeout" : [60,60] }}
   ```
   
   The problem is this file isn't a plain config file, it's actually a giant python format
string.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message