airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] potiuk commented on a change in pull request #5836: [AIRFLOW-5234] Rst files have consistent, auto-added license
Date Fri, 16 Aug 2019 18:29:55 GMT
potiuk commented on a change in pull request #5836: [AIRFLOW-5234] Rst files have consistent,
auto-added license
URL: https://github.com/apache/airflow/pull/5836#discussion_r314840516
 
 

 ##########
 File path: docs/howto/operator/gcp/gcs.rst
 ##########
 @@ -1,20 +1,22 @@
-..  Licensed to the Apache Software Foundation (ASF) under one
+ .. Licensed to the Apache Software Foundation (ASF) under one
 
 Review comment:
   The pre-commit plugin always adds space for non-empty license lines. It works well for
all other cases but for .rst files it does not. I figured that it is better to change .rst
files to adapt rather than customise the plugin. The benefit of the pre-commit is that it
adds licences automatically and you do not have to even think about licenses any more once
you start using it, so I think it is a small price to pay with once-off space offset for .rst
files. I double-checked that it works fine when documentatio.n is generated.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message