airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] potiuk commented on a change in pull request #5839: [AIRFLOW-5236] dont reload pip packages for every k8s build
Date Fri, 16 Aug 2019 14:47:02 GMT
potiuk commented on a change in pull request #5839: [AIRFLOW-5236] dont reload pip packages
for every k8s build
URL: https://github.com/apache/airflow/pull/5839#discussion_r314753060
 
 

 ##########
 File path: scripts/ci/kubernetes/docker/build.sh
 ##########
 @@ -50,5 +50,10 @@ sudo rm -rf "${AIRFLOW_ROOT}/airflow/www_rbac/node_modules"
 
 echo "Copy distro ${AIRFLOW_ROOT}/dist/*.tar.gz ${DIRNAME}/airflow.tar.gz"
 cp ${AIRFLOW_ROOT}/dist/*.tar.gz "${DIRNAME}/airflow.tar.gz"
-cd "${DIRNAME}" && docker build --pull "${DIRNAME}" --tag="${IMAGE}:${TAG}"
+pip freeze | grep -v airflow | grep -v postgres > requirements.txt
+if [[  "${DO_NOT_PULL}" ]]; then
 
 Review comment:
   Nit: Maybe use AIRFLOW_CONTAINER_SKIP_PULLING_AIRFLOW_IMAGES == "true" ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message