airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] potiuk commented on issue #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks
Date Mon, 12 Aug 2019 11:16:12 GMT
potiuk commented on issue #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit
hooks
URL: https://github.com/apache/airflow/pull/5777#issuecomment-520384668
 
 
   Hey @dimberman  (and others ;) - @BasPH ). I made a slight improvement to pre-commit framework.
Now it is not only used by pre-commit hook but also for travis CI tests (with --all-files
switch) for all static checks in one job (except pylint). This saves quite a lot of overhead
for booting VMs on travis - we have less jobs to handle and it's rather fast. Also as we add
more static checks they will be run automatically as we add them in the same job. And people
will get used to the pre-commit interface showing passsed/failed. See https://travis-ci.org/apache/airflow/jobs/570789001
for the job that runs the static checks.
   
   I have more separate PRs to add more static checks which I will add separately.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message