airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] nuclearpinguin commented on a change in pull request #5717: [AIRFLOW-5052] Added the include_deleted params to salesforce make_query
Date Fri, 09 Aug 2019 14:52:13 GMT
nuclearpinguin commented on a change in pull request #5717: [AIRFLOW-5052] Added the include_deleted
params to salesforce make_query
URL: https://github.com/apache/airflow/pull/5717#discussion_r312516709
 
 

 ##########
 File path: airflow/contrib/hooks/salesforce_hook.py
 ##########
 @@ -73,19 +73,21 @@ def get_conn(self):
             )
         return self.conn
 
-    def make_query(self, query):
+    def make_query(self, query, include_deleted=False, **kwargs):
 
 Review comment:
   I think that it would be better to use something like `query_params: dict` instead of `**kwargs`
to indicate that a user can pass additional parameters too query method.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message