airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] BasPH commented on issue #5461: [AIRFLOW-4835] Refactor render_template
Date Sat, 03 Aug 2019 08:36:57 GMT
BasPH commented on issue #5461: [AIRFLOW-4835] Refactor render_template
URL: https://github.com/apache/airflow/pull/5461#issuecomment-517906672
 
 
   @ashb addressed your comments. I've created `tests/models/test_baseoperator.py` (this didn't
exist to my surprise) because some logic from the TaskInstance moved to the BaseOperator.
In addition, I added a test to verify if a Jinja environment is instantiated only once, even
with multiple templated fields (`test_jinja_env_creation` in `tests/models/test_baseoperator.py`).
   
   I think a few bits and pieces could still improve (e.g. `render_template` could be a staticmethod,
because it doesn't read anything directly from `self`, sets are currently not templatable),
etc... but think we should also keep the PR as small as possible. With that idea, if all is
okay logically, is this okay now? 🙂

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message