airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-3792) Bigquery hook no longer accepts queryParameters and use_legacy_sql=False
Date Tue, 12 Feb 2019 23:41:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-3792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16766582#comment-16766582
] 

ASF subversion and git services commented on AIRFLOW-3792:
----------------------------------------------------------

Commit 0c797a830e3370bd6e39f5fcfc128a8fd776912e in airflow's branch refs/heads/master from
Olivier Girardot
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=0c797a8 ]

[AIRFLOW-3792] Fix validation in BQ for useLegacySQL & queryParameters (#4626)



> Bigquery hook no longer accepts queryParameters and use_legacy_sql=False
> ------------------------------------------------------------------------
>
>                 Key: AIRFLOW-3792
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3792
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: contrib, gcp
>    Affects Versions: 1.10.0, 1.10.1, 1.10.2
>         Environment: any OS but when using BigQuery
>            Reporter: Olivier Girardot
>            Assignee: Olivier Girardot
>            Priority: Major
>
> Since AIRFLOW-491 with PR [https://github.com/apache/airflow/pull/3733] there is a
regression induced that make queryParameters unusable in `BigQueryBaseCursor.run_query` and
is a bit inconsistent when `use_legacy_sql` flag is set to false, because it only accepts
None even though the parameter is a bool.
> For the use_legacy_sql flag there is only a simple condition to add, and for queryParameters
the check_param expects a dict but google's api expects a list of dict. c.f. 
> |{{configuration.query.queryParameters[]}}|
> in [https://cloud.google.com/bigquery/docs/reference/rest/v2/jobs#configuration.query]
> PR will soon be opened after this issue 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message