airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-3792) Bigquery hook no longer accepts queryParameters and use_legacy_sql=False
Date Tue, 12 Feb 2019 23:41:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-3792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16766581#comment-16766581
] 

ASF GitHub Bot commented on AIRFLOW-3792:
-----------------------------------------

kaxil commented on pull request #4626: [AIRFLOW-3792] Fix in BigQuery hook queryParameters
and useLegacySQL flags
URL: https://github.com/apache/airflow/pull/4626
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Bigquery hook no longer accepts queryParameters and use_legacy_sql=False
> ------------------------------------------------------------------------
>
>                 Key: AIRFLOW-3792
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3792
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: contrib, gcp
>    Affects Versions: 1.10.0, 1.10.1, 1.10.2
>         Environment: any OS but when using BigQuery
>            Reporter: Olivier Girardot
>            Assignee: Olivier Girardot
>            Priority: Major
>
> Since AIRFLOW-491 with PR [https://github.com/apache/airflow/pull/3733] there is a
regression induced that make queryParameters unusable in `BigQueryBaseCursor.run_query` and
is a bit inconsistent when `use_legacy_sql` flag is set to false, because it only accepts
None even though the parameter is a bool.
> For the use_legacy_sql flag there is only a simple condition to add, and for queryParameters
the check_param expects a dict but google's api expects a list of dict. c.f. 
> |{{configuration.query.queryParameters[]}}|
> in [https://cloud.google.com/bigquery/docs/reference/rest/v2/jobs#configuration.query]
> PR will soon be opened after this issue 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message