airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] kaxil commented on a change in pull request #4607: WIP: [AIRFLOW-1894] Google cloud bigquery
Date Tue, 12 Feb 2019 23:32:20 GMT
kaxil commented on a change in pull request #4607: WIP: [AIRFLOW-1894] Google cloud bigquery
URL: https://github.com/apache/airflow/pull/4607#discussion_r256192035
 
 

 ##########
 File path: airflow/contrib/operators/bigquery_operator.py
 ##########
 @@ -497,8 +482,8 @@ def execute(self, context):
             quote_character=self.quote_character,
             allow_quoted_newlines=self.allow_quoted_newlines,
             allow_jagged_rows=self.allow_jagged_rows,
-            src_fmt_configs=self.src_fmt_configs,
-            labels=self.labels
+            external_config_options=self.external_config_options,
 
 Review comment:
   This will have to be for 2.0 as it will break things. Also, it needs to be backward-compatible
to make updation smooth from 1.X to 2.0

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message