airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] kaxil commented on a change in pull request #4665: [AIRFLOW-3701] Google Cloud Vision Product Search operators
Date Tue, 12 Feb 2019 23:19:42 GMT
kaxil commented on a change in pull request #4665: [AIRFLOW-3701] Google Cloud Vision Product
Search operators
URL: https://github.com/apache/airflow/pull/4665#discussion_r256187402
 
 

 ##########
 File path: airflow/contrib/hooks/gcp_vision_hook.py
 ##########
 @@ -0,0 +1,252 @@
+# -*- coding: utf-8 -*-
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+import re
+
+from google.api_core.exceptions import AlreadyExists, GoogleAPICallError, RetryError
+from google.cloud.vision_v1 import ProductSearchClient
+from google.cloud.vision_v1.proto.product_search_service_pb2 import Product
+from google.protobuf.json_format import MessageToJson
+
+from airflow import AirflowException
+from airflow.contrib.hooks.gcp_api_base_hook import GoogleCloudBaseHook
+
+PARENT_TEMPLATE = 'projects/{}/locations/{}'
+PRODUCT_SET_NAME_TEMPLATE = 'projects/{}/locations/{}/productSets/{}'
+PRODUCT_NAME_TEMPLATE = 'projects/{}/locations/{}/products/{}'
+
+
+# noinspection PyAbstractClass
 
 Review comment:
   We should remove any `noinspection` stuff. Let's aim to fix this on BaseOperator level.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message