airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-1552) Airflow Filter_by_owner not working with password_auth
Date Tue, 04 Dec 2018 14:42:01 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16708787#comment-16708787
] 

ASF GitHub Bot commented on AIRFLOW-1552:
-----------------------------------------

thomasbrockmeier opened a new pull request #4276: [AIRFLOW-1552] Query PasswordUser on password
login
URL: https://github.com/apache/incubator-airflow/pull/4276
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] Fix [AIRFLOW-1552](https://issues.apache.org/jira/browse/AIRFLOW-1552), Airflow filter_by_owner
not working with password_auth
   
   ### Description
   
   - [x]  Here are some details about my PR, including screenshots of any UI changes:
   `airflow.contrib.auth.backends.password_auth.load_user` would query `models.User` and cast
the result to `PasswordUser` instead of querying `PasswordUser` directly
   
   ### Tests
   
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Code Quality
   
   - [x] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Airflow Filter_by_owner not working with password_auth
> ------------------------------------------------------
>
>                 Key: AIRFLOW-1552
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-1552
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: configuration
>    Affects Versions: 1.8.0
>         Environment: CentOS , python 2.7
>            Reporter: raghu ram reddy
>            Priority: Major
>
> Airflow Filter_by_owner parameter is not working with password_auth.
> I created sample user using the below code from airflow documentation and enabled password_auth.
> I'm able to login as the user created but by default this user is superuser and there
is noway to modify it, default all users created by PasswordUser are superusers.
> import airflow
> from airflow import models, settings
> from airflow.contrib.auth.backends.password_auth import PasswordUser
> user = PasswordUser(models.User())
> user.username = 'test1'
> user.password = 'test1'
> user.is_superuser()
> session = settings.Session()
> session.add(user)
> session.commit()
> session.close()
> exit()



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message