airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] MarcusSorealheis commented on issue #4295: AIRFLOW-3452 removed an unused/dangerous display-none
Date Sat, 08 Dec 2018 00:05:52 GMT
MarcusSorealheis commented on issue #4295: AIRFLOW-3452 removed an unused/dangerous display-none
URL: https://github.com/apache/incubator-airflow/pull/4295#issuecomment-445407824
 
 
   Furthermore @OldPanda, `display:none`, though not nearly as dangerous or comprisable as
something like `eval` on the front end, it should still be wholly avoided. One of the reasons
we should avoid it is because `display:none` [hides all its child text from screen readers]
(https://css-tricks.com/places-its-tempting-to-use-display-none-but-dont/) and that's bad.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message