airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] XD-DENG commented on a change in pull request #4287: [AIRFLOW-3479] Keeps records in Log Table when delete DAG & refine related tests
Date Fri, 07 Dec 2018 08:40:57 GMT
XD-DENG commented on a change in pull request #4287: [AIRFLOW-3479] Keeps records in Log Table
when delete DAG & refine related tests
URL: https://github.com/apache/incubator-airflow/pull/4287#discussion_r239729799
 
 

 ##########
 File path: airflow/api/common/experimental/delete_dag.py
 ##########
 @@ -41,6 +49,8 @@ def delete_dag(dag_id):
     # noinspection PyUnresolvedReferences,PyProtectedMember
     for m in models.Base._decl_class_registry.values():
         if hasattr(m, "dag_id"):
+            if keep_records_in_log and m.__name__ == 'Log':
 
 Review comment:
   Thanks @feng-tao . May you help re-trigger the Travis test?
   
   Earlier most my test cases failed due to un-related tests. I believe it's some sort of
transient errors.
   
   Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message