airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] kaxil commented on a change in pull request #4282: [AIRFLOW-XXX] Add Docstrings as Requirement in Contribution template
Date Wed, 05 Dec 2018 20:02:50 GMT
kaxil commented on a change in pull request #4282: [AIRFLOW-XXX] Add Docstrings as Requirement
in Contribution template
URL: https://github.com/apache/incubator-airflow/pull/4282#discussion_r239216387
 
 

 ##########
 File path: .github/PULL_REQUEST_TEMPLATE.md
 ##########
 @@ -28,6 +28,7 @@ Make sure you have checked _all_ steps below.
 
 - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
   - When adding new operators/hooks/sensors, the autoclass documentation generation needs
to be added.
+  - All the functions and the classes in the PR contain docstrings that explain what it does
 
 Review comment:
   Done, updated. 
   
   https://pep8.org/#descriptive-naming-styles
   >The underscore prefix is meant as a hint to another programmer that a variable or method
starting with a single underscore is intended for internal use. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message