airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] draksler commented on a change in pull request #3733: [AIRFLOW-491] Add cache parameter in BigQuery query method - with 'api_resource_configs'
Date Mon, 03 Dec 2018 17:34:35 GMT
draksler commented on a change in pull request #3733: [AIRFLOW-491] Add cache parameter in
BigQuery query method - with 'api_resource_configs'
URL: https://github.com/apache/incubator-airflow/pull/3733#discussion_r238365698
 
 

 ##########
 File path: airflow/contrib/hooks/bigquery_hook.py
 ##########
 @@ -473,11 +482,11 @@ def create_external_table(self,
     def run_query(self,
                   bql=None,
                   sql=None,
-                  destination_dataset_table=False,
+                  destination_dataset_table=None,
                   write_disposition='WRITE_EMPTY',
                   allow_large_results=False,
-                  flatten_results=None,
-                  udf_config=False,
+                  flatten_results=False,
 
 Review comment:
   I've opened a jira [here](https://issues.apache.org/jira/browse/AIRFLOW-3438), if it is
a duplicate please close it. 
   Tests would normally not cover this case, as you would mock the whole hook, not part of
it. It is unfortunate that the docstring was incorrect though.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message