From commits-return-28662-archive-asf-public=cust-asf.ponee.io@airflow.incubator.apache.org Fri Nov 23 20:38:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E1AF1180660 for ; Fri, 23 Nov 2018 20:38:04 +0100 (CET) Received: (qmail 24886 invoked by uid 500); 23 Nov 2018 19:38:04 -0000 Mailing-List: contact commits-help@airflow.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.incubator.apache.org Delivered-To: mailing list commits@airflow.incubator.apache.org Received: (qmail 24877 invoked by uid 99); 23 Nov 2018 19:38:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Nov 2018 19:38:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 81B4AC030E for ; Fri, 23 Nov 2018 19:38:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id vG52ZZwqmTHn for ; Fri, 23 Nov 2018 19:38:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 37DC360D94 for ; Fri, 23 Nov 2018 19:38:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8845FE04AD for ; Fri, 23 Nov 2018 19:38:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0E21A2135D for ; Fri, 23 Nov 2018 19:38:00 +0000 (UTC) Date: Fri, 23 Nov 2018 19:38:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@airflow.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AIRFLOW-1196) Make trigger_dag_id a templated field of TriggerDagRunOperator MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AIRFLOW-1196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697460#comment-16697460 ] ASF GitHub Bot commented on AIRFLOW-1196: ----------------------------------------- kaxil opened a new pull request #4228: [AIRFLOW-1196][AIRFLOW-2399] Add templated field in TriggerDagRunOperator URL: https://github.com/apache/incubator-airflow/pull/4228 Make trigger_dag_id a templated field of TriggerDagRunOperator Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. - https://issues.apache.org/jira/browse/AIRFLOW-1196 - https://issues.apache.org/jira/browse/AIRFLOW-2399 ### Description - [x] Here are some details about my PR, including screenshots of any UI changes: Make `trigger_dag_id` a templated field of `TriggerDagRunOperator` ### Tests - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: n/a ### Commits - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation - [x] In case of new functionality, my PR adds documentation that describes how to use it. - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added. ### Code Quality - [x] Passes `flake8` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > Make trigger_dag_id a templated field of TriggerDagRunOperator > -------------------------------------------------------------- > > Key: AIRFLOW-1196 > URL: https://issues.apache.org/jira/browse/AIRFLOW-1196 > Project: Apache Airflow > Issue Type: Improvement > Components: operators > Reporter: Arthur Vigil > Assignee: Arthur Vigil > Priority: Trivial > Labels: easyfix, improvement > > TriggerDagRunOperator currently has no templated fields. Adding `trigger_dag_id` as a templated field should be a trivial change that improves its flexibility and usefulness. -- This message was sent by Atlassian JIRA (v7.6.3#76005)