airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-3392) Add index on dag_id in sla_miss table
Date Tue, 27 Nov 2018 05:50:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16699947#comment-16699947
] 

ASF GitHub Bot commented on AIRFLOW-3392:
-----------------------------------------

feng-tao closed pull request #4235: [AIRFLOW-3392] Add index on dag_id in sla_miss table
URL: https://github.com/apache/incubator-airflow/pull/4235
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/airflow/migrations/versions/03bc53e68815_add_sm_dag_index.py b/airflow/migrations/versions/03bc53e68815_add_sm_dag_index.py
new file mode 100644
index 0000000000..fc8468155c
--- /dev/null
+++ b/airflow/migrations/versions/03bc53e68815_add_sm_dag_index.py
@@ -0,0 +1,40 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+"""merge_heads_2
+
+Revision ID: 03bc53e68815
+Revises: 0a2a5b66e19d, bf00311e1990
+Create Date: 2018-11-24 20:21:46.605414
+
+"""
+
+from alembic import op
+
+# revision identifiers, used by Alembic.
+revision = '03bc53e68815'
+down_revision = ('0a2a5b66e19d', 'bf00311e1990')
+branch_labels = None
+depends_on = None
+
+
+def upgrade():
+    op.create_index('sm_dag', 'sla_miss', ['dag_id'], unique=False)
+
+
+def downgrade():
+    op.drop_index('sm_dag', table_name='sla_miss')
diff --git a/airflow/models.py b/airflow/models.py
index 9ab2348cc2..4b8b7dc5c9 100755
--- a/airflow/models.py
+++ b/airflow/models.py
@@ -5481,6 +5481,10 @@ class SlaMiss(Base):
     description = Column(Text)
     notification_sent = Column(Boolean, default=False)
 
+    __table_args__ = (
+        Index('sm_dag', dag_id, unique=False),
+    )
+
     def __repr__(self):
         return str((
             self.dag_id, self.task_id, self.execution_date.isoformat()))


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add index on dag_id in sla_miss table
> -------------------------------------
>
>                 Key: AIRFLOW-3392
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3392
>             Project: Apache Airflow
>          Issue Type: Improvement
>            Reporter: Kevin Yang
>            Assignee: Kevin Yang
>            Priority: Major
>
> The select queries on sla_miss table produce a great % of DB traffic and thus made the
DB CPU usage unnecessarily high. It would be a low hanging fruit to add an index and reduce
the load.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message