airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Iuliia Volkova (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (AIRFLOW-3358) POC: Refactor command line to make it more testable and easy to develop
Date Sat, 17 Nov 2018 07:42:00 GMT

     [ https://issues.apache.org/jira/browse/AIRFLOW-3358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Iuliia Volkova updated AIRFLOW-3358:
------------------------------------
    Description: 
Hi all! 

In one of PR: https://github.com/apache/incubator-airflow/pull/4174 we had a talk with Ashb,
what will be cool to refactor the cli for getting more testable and readable code.

I want to prepare POC based on one command with implementation (with Click if we want it to
use, or with Argparse and Command Pattern) and covering with tests for discussing Airflow
Cli architecture.


Click already exists in Airflow dependencies.

Main stimulus: 

- Get more readable and changeable cli - for easy adding command or changing commands
- Get possible to add more tests 

 Will be good to know your concerns about such initiative and if there are no disagrees about
it, I will be happy to start POC

  was:
Hi all! 

In one of PR: https://github.com/apache/incubator-airflow/pull/4174 we had a talk with Ashb,
what will be cool to refactor the cli for getting more testable and readable code.

I want to prepare POC based on one command with implementation with Click and covering with
tests for discussing Airflow Cli architecture.


Click already exists in Airflow dependencies.

Main stimulus: 

- Get more readable and changeable cli - for easy adding command or changing commands
- Get possible to add more tests 

 Will be good to know your concerns about such initiative and if there are no disagrees about
it, I will be happy to start POC


> POC: Refactor command line to make it  more testable and easy to develop
> ------------------------------------------------------------------------
>
>                 Key: AIRFLOW-3358
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3358
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: cli
>    Affects Versions: 2.0.0
>            Reporter: Iuliia Volkova
>            Assignee: Iuliia Volkova
>            Priority: Major
>
> Hi all! 
> In one of PR: https://github.com/apache/incubator-airflow/pull/4174 we had a talk with
Ashb, what will be cool to refactor the cli for getting more testable and readable code.
> I want to prepare POC based on one command with implementation (with Click if we want
it to use, or with Argparse and Command Pattern) and covering with tests for discussing Airflow
Cli architecture.
> Click already exists in Airflow dependencies.
> Main stimulus: 
> - Get more readable and changeable cli - for easy adding command or changing commands
> - Get possible to add more tests 
>  Will be good to know your concerns about such initiative and if there are no disagrees
about it, I will be happy to start POC



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message