airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-3348) Refresh run stats on dag refresh
Date Thu, 15 Nov 2018 22:21:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-3348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688723#comment-16688723
] 

ASF GitHub Bot commented on AIRFLOW-3348:
-----------------------------------------

ms32035 opened a new pull request #4197:  [AIRFLOW-3348] update run statistics on dag refresh
URL: https://github.com/apache/incubator-airflow/pull/4197
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [X] My PR addresses the following [Airflow Jira]
     - https://issues.apache.org/jira/browse/AIRFLOW-3348
   
   ### Description
   
   - [X] Here are some details about my PR, including screenshots of any UI changes:
   
   In some cases dag run statistics may become outdated, for example, when dag run is deleted.
   
   As the view from which dag runs are deleted permits to delete runs from multiple dags in
a single transaction, this seems to be the most reasonable place to update run statistics
   
   ### Tests
   
   - [X] My PR does not need testing for this extremely good reason:
    Covered by existing test for `/refresh`
   
   ### Commits
   
   - [X ] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [X ] In case of new functionality, my PR adds documentation that describes how to use
it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs
to be added.
   
   ### Code Quality
   
   - [X ] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Refresh run stats on dag refresh
> --------------------------------
>
>                 Key: AIRFLOW-3348
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3348
>             Project: Apache Airflow
>          Issue Type: Improvement
>            Reporter: Marcin Szymanski
>            Assignee: Marcin Szymanski
>            Priority: Minor
>
> In some cases dag run statistics may become outdated, for example, when dag run is deleted.
> As the view from which dag runs are deleted permits to delete runs from multiple dags
in a single transaction, this seems to be the most reasonable place to update run statistics



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message