airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-3306) Disable unused flask-sqlalchemy modification tracking
Date Tue, 06 Nov 2018 19:31:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-3306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677212#comment-16677212
] 

ASF GitHub Bot commented on AIRFLOW-3306:
-----------------------------------------

jmcarp opened a new pull request #4146: [AIRFLOW-3306] Disable flask-sqlalchemy modification
tracking.
URL: https://github.com/apache/incubator-airflow/pull/4146
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/)
issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-3306
     - In case you are fixing a typo in the documentation you can prepend your commit with
\[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   By default, flask-sqlalchemy tracks model changes for its event system, which adds some
overhead. Since I don't think we're using the flask-sqlalchemy event system, we should be
able to turn off modification tracking and improve performance.
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   
   Just a config change; existing tests should cover it.
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use
it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs
to be added.
   
   ### Code Quality
   
   - [x] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Disable unused flask-sqlalchemy modification tracking
> -----------------------------------------------------
>
>                 Key: AIRFLOW-3306
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3306
>             Project: Apache Airflow
>          Issue Type: Bug
>            Reporter: Josh Carp
>            Assignee: Josh Carp
>            Priority: Trivial
>
> By default, flask-sqlalchemy tracks model changes for its event system, which adds some
overhead. Since I don't think we're using the flask-sqlalchemy event system, we should be
able to turn off modification tracking and improve performance.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message