airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-3272) Create gRPC hook for creating generic grpc connection
Date Mon, 05 Nov 2018 22:11:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675814#comment-16675814
] 

ASF GitHub Bot commented on AIRFLOW-3272:
-----------------------------------------

morgendave opened a new pull request #4101: [AIRFLOW-3272] Add base grpc hook
URL: https://github.com/apache/incubator-airflow/pull/4101
 
 
   Make sure you have checked all steps below.
   
   Jira
     My PR addresses the following Airflow Jira issues and references them in the PR title.
For example, "[AIRFLOW-3272] My Airflow PR"
   https://issues.apache.org/jira/browse/AIRFLOW-3272
   Description
     Add support for gRPC connection in airflow. 
   
   In Airflow there are use cases of calling gPRC services, so instead of each time create
the channel in a PythonOperator, there should be a basic GrpcHook to take care of it. The
hook needs to take care of the authentication.
   
   Tests
     My PR adds the following unit tests OR does not need testing for this extremely good
reason:
   Commits
     My commits all reference Jira issues in their subject lines, and I have squashed multiple
commits if they address the same issue. In addition, my commits follow the guidelines from
"How to write a good git commit message":
   Subject is separated from body by a blank line
   Subject is limited to 50 characters (not including Jira issue reference)
   Subject does not end with a period
   Subject uses the imperative mood ("add", not "adding")
   Body wraps at 72 characters
   Body explains "what" and "why", not "how"
   Documentation
     In case of new functionality, my PR adds documentation that describes how to use it.
   When adding new operators/hooks/sensors, the autoclass documentation generation needs to
be added.
   Code Quality
     Passes flake8

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Create gRPC hook for creating generic grpc connection
> -----------------------------------------------------
>
>                 Key: AIRFLOW-3272
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3272
>             Project: Apache Airflow
>          Issue Type: Improvement
>            Reporter: Zhiwei Zhao
>            Assignee: Zhiwei Zhao
>            Priority: Minor
>
> Add support for gRPC connection in airflow. 
> In Airflow there are use cases of calling gPRC services, so instead of each time create
the channel in a PythonOperator, there should be a basic GrpcHook to take care of it. The
hook needs to take care of the authentication.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message