airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-3262) Can't get log containing Response when using SimpleHttpOperator
Date Mon, 05 Nov 2018 16:36:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675413#comment-16675413
] 

ASF GitHub Bot commented on AIRFLOW-3262:
-----------------------------------------

kaxil opened a new pull request #4135: [AIRFLOW-3262] Update SimpleHttpOpTests to check Example.com
URL: https://github.com/apache/incubator-airflow/pull/4135
 
 
   
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/)
issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-3262
   
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   Update SimpleHttpOpTests to check Example.com instead of Google.com so that the ip doesn't
get banned.
   
   Currently, test in v1.10-test is failing
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use
it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs
to be added.
   
   ### Code Quality
   
   - [x] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Can't get log containing Response when using SimpleHttpOperator
> ---------------------------------------------------------------
>
>                 Key: AIRFLOW-3262
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3262
>             Project: Apache Airflow
>          Issue Type: Improvement
>            Reporter: Kaxil Naik
>            Assignee: Kaxil Naik
>            Priority: Trivial
>             Fix For: 1.10.1
>
>
> When you use SimpleHttpOperator for things like ElasticSearch, you want to get the response
in the logs as well. Currently, the only workaround is to use `xcom_push` and push the content
to xcom and in the next task get the response.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message