airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-3220) Implement Instance Group Managers operators for GCE
Date Fri, 09 Nov 2018 11:23:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-3220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681292#comment-16681292
] 

ASF GitHub Bot commented on AIRFLOW-3220:
-----------------------------------------

potiuk opened a new pull request #4167: [AIRFLOW-3220] Implement Instance Group Manager Operators
for GCE
URL: https://github.com/apache/incubator-airflow/pull/4167
 
 
   ### Jira
   
   - [x] My PR addresses the following [Implement Instance Group Managers operators for GCE](https://issues.apache.org/jira/browse/AIRFLOW-3220)
issue and references them in the PR title. 
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   There are two operators:
   * GceInstanceTemplateCopy - existing template is copied with some
   changes specified
   * GceInstanceGroupManagerUpdateVersion - template is replaced in
   the instance group manager with patch method
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   tests.contrib.operators.test_gcp_compute_operator.
      GceInstanceTemplateCopyTest
      GceInstanceGroupManagerUpdateTest
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use
it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs
to be added.
   
   ### Code Quality
   
   - [x] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Implement Instance Group Managers operators for GCE
> ---------------------------------------------------
>
>                 Key: AIRFLOW-3220
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3220
>             Project: Apache Airflow
>          Issue Type: New Feature
>            Reporter: Jarek Potiuk
>            Priority: Major
>
> In order to be able to manage Instance Group Managers templates for instances:
> [https://cloud.google.com/compute/docs/reference/rest/v1/instanceGroupManagers] 
> Two operators are needed:
>  * GceInstanceTemplateCopy - where existing template is copied with some changes specified
(using API from https://cloud.google.com/compute/docs/reference/rest/v1/instanceTemplates)
>  * GceInstanceGroupManagerUpdateVersion -  where updated template is replaced in the
instance group manager with patch method: https://cloud.google.com/compute/docs/reference/rest/beta/instanceGroupManagers/patch



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message