airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-2715) Dataflow template operator dosenot support region parameter
Date Tue, 06 Nov 2018 08:23:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-2715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676330#comment-16676330
] 

ASF GitHub Bot commented on AIRFLOW-2715:
-----------------------------------------

janhicken opened a new pull request #4139: [AIRFLOW-2715] Pick up the region setting while
launching Dataflow templates
URL: https://github.com/apache/incubator-airflow/pull/4139
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW-2715)
issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
     - In case you are fixing a typo in the documentation you can prepend your commit with
\[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   To launch an instance of a Dataflow template in the configured region,
   the API service.projects().locations().teplates() instead of
   service.projects().templates() has to be used. Otherwise, all jobs will
   always be started in us-central1.
   
   In case there is no region configured, the default region `us-central1` will get picked
up.
   
   To make it even worse, the polling for the job status already honors the
   region parameter and will search for the job in the wrong region in the
   current implementation. Because the job's status is not found, the
   corresponding Airflow task will hang.
   
   This PR is a second approach and follow-up of #4125
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   `tests.contrib.hooks.test_gcp_dataflow_hook.DataFlowTemplateHookTest` has been modified
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use
it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs
to be added.
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Dataflow template operator dosenot support region parameter
> -----------------------------------------------------------
>
>                 Key: AIRFLOW-2715
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2715
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: operators
>    Affects Versions: 1.9.0
>            Reporter: Mohammed Tameem
>            Priority: Critical
>             Fix For: 2.0.0
>
>
> The DataflowTemplateOperator  uses dataflow.projects.templates.launch which has a region
parameter but only supports execution of the dataflow job in the us-central1 region. Alternatively 
there is another api, dataflow.projects.locations.templates.launch which supports execution
of the template in all regional endpoints provided by google cloud.
> It would be great if,
>  # The base REST API of this operator could be changed from "dataflow.projects.templates.launch"
to "dataflow.projects.locations.templates.launch"
>  # A templated region paramter was included in the operator to run the dataflow job in
the requested regional endpoint.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message