airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-1196) Make trigger_dag_id a templated field of TriggerDagRunOperator
Date Fri, 23 Nov 2018 19:38:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-1196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697460#comment-16697460
] 

ASF GitHub Bot commented on AIRFLOW-1196:
-----------------------------------------

kaxil opened a new pull request #4228: [AIRFLOW-1196][AIRFLOW-2399] Add templated field in
TriggerDagRunOperator
URL: https://github.com/apache/incubator-airflow/pull/4228
 
 
   Make trigger_dag_id a templated field of TriggerDagRunOperator
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/)
issues and references them in the PR title.
     - https://issues.apache.org/jira/browse/AIRFLOW-1196
     - https://issues.apache.org/jira/browse/AIRFLOW-2399
   
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   Make `trigger_dag_id` a templated field of `TriggerDagRunOperator`
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   n/a
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use
it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs
to be added.
   
   ### Code Quality
   
   - [x] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Make trigger_dag_id a templated field of TriggerDagRunOperator
> --------------------------------------------------------------
>
>                 Key: AIRFLOW-1196
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-1196
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: operators
>            Reporter: Arthur Vigil
>            Assignee: Arthur Vigil
>            Priority: Trivial
>              Labels: easyfix, improvement
>
> TriggerDagRunOperator currently has no templated fields. Adding `trigger_dag_id` as a
templated field should be a trivial change that improves its flexibility and usefulness.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message