airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] XD-DENG commented on a change in pull request #4253: [AIRFLOW-3414] Fix reload_module in DagFileProcessorAgent
Date Fri, 30 Nov 2018 02:06:45 GMT
XD-DENG commented on a change in pull request #4253: [AIRFLOW-3414] Fix reload_module in DagFileProcessorAgent
URL: https://github.com/apache/incubator-airflow/pull/4253#discussion_r237724308
 
 

 ##########
 File path: airflow/logging_config.py
 ##########
 @@ -73,7 +73,7 @@ def configure_logging():
 
     validate_logging_config(logging_config)
 
-    return logging_config
+    return logging_config, logging_class_path
 
 Review comment:
   Thanks @KevinYang21 !
   
   Is there any specific reason that we need to return `logging_config`?
   
   **Before this PR**:
   
   `configure_logging()` is invoked in `airflow/settings.py`, but seems what it returns is
not used (its return value is not passed to any variable actually, https://github.com/apache/incubator-airflow/pull/4253/files#diff-535b21d0d7b5e33649e0eb521b41f157L264).
   
   **After this PR**:
   
   `logging_class_path` is returned by `configure_logging()`, then used in `airflow/utils/dag_processing.py`.
   
   But `logging_config` is still not used anywhere.
   
   
   So I'm thinking if we really need to include `logging_config` in the return values?
   
   Kindly let me know if I missed anything (quite likely). Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message