airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ashb commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos…
Date Wed, 28 Nov 2018 11:24:35 GMT
ashb commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab
and principal to kerberos…
URL: https://github.com/apache/incubator-airflow/pull/4238#discussion_r237042420
 
 

 ##########
 File path: airflow/security/kerberos.py
 ##########
 @@ -80,10 +82,8 @@ def perform_krb181_workaround():
     ret = subprocess.call(cmdv, close_fds=True)
 
     if ret != 0:
-        principal = "%s/%s" % (
-            configuration.conf.get('kerberos', 'principal'),
-            socket.getfqdn()
-        )
+        principal = "%s/%s" % (configuration.conf.get('kerberos', 'principal'),
 
 Review comment:
   ```suggestion
           principal = "%s/%s" % (principal or configuration.conf.get('kerberos', 'principal'),
   ```
   
   which will need the principal var passed to this function. Maybe just `principal = "%s/%s"
% (principal,` would do then

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message