airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] xnuinside commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos…
Date Mon, 26 Nov 2018 18:02:32 GMT
xnuinside commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args
keytab and principal to kerberos…
URL: https://github.com/apache/incubator-airflow/pull/4238#discussion_r236364587
 
 

 ##########
 File path: airflow/security/kerberos.py
 ##########
 @@ -110,11 +112,11 @@ def detect_conf_var():
         return b'X-CACHECONF:' in f.read()
 
 
-def run():
-    if configuration.conf.get('kerberos', 'keytab') is None:
+def run(args):
+    if not args.keytab:
 
 Review comment:
   no, it not needed, because we get configuration.conf.get('kerberos', 'keytab') as default
value in arg - https://github.com/apache/incubator-airflow/blob/master/airflow/bin/cli.py#L1685
, so if args.keytabe will be None it mean what config empty too

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message