airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] xnuinside commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args keytab and principal to kerberos…
Date Mon, 26 Nov 2018 16:47:04 GMT
xnuinside commented on a change in pull request #4238: [AIRFLOW-987] pass kerberos cli args
keytab and principal to kerberos…
URL: https://github.com/apache/incubator-airflow/pull/4238#discussion_r236334789
 
 

 ##########
 File path: airflow/security/kerberos.py
 ##########
 @@ -55,8 +57,8 @@ def renew_from_kt():
     if subp.returncode != 0:
         log.error("Couldn't reinit from keytab! `kinit' exited with %s.\n%s\n%s" % (
             subp.returncode,
-            b"\n".join(subp.stdout.readlines()),
-            b"\n".join(subp.stderr.readlines())))
+            "\n".join(subp.stdout.readlines()),
+            "\n".join(subp.stderr.readlines())))
 
 Review comment:
   Do we still need these lines? https://github.com/apache/incubator-airflow/blob/master/airflow/bin/airflow#L26-L28
- I don't know :/ i fix only bug, what args from cli not passed to kerberos.run, but they
are defined in cli doc 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message