airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] bolkedebruin commented on a change in pull request #4233: [AIRFLOW-3391] Upgrade pendulum. to latest major version.
Date Sun, 25 Nov 2018 16:01:24 GMT
bolkedebruin commented on a change in pull request #4233: [AIRFLOW-3391] Upgrade pendulum.
to latest major version.
URL: https://github.com/apache/incubator-airflow/pull/4233#discussion_r236078997
 
 

 ##########
 File path: tests/models.py
 ##########
 @@ -230,9 +230,9 @@ def test_dag_topological_sort(self):
         self.assertEquals(tuple(), dag.topological_sort())
 
     def test_dag_naive_default_args_start_date(self):
-        dag = DAG('DAG', default_args={'start_date': datetime.datetime(2018, 1, 1)})
+        dag = DAG('DAG', default_args={'start_date': timezone.datetime(2018, 1, 1)})
 
 Review comment:
   This is not naive?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message